qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Fix tiny leak in qemu_opts_parse


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH] Fix tiny leak in qemu_opts_parse
Date: Mon, 03 May 2010 12:14:00 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0pre Thunderbird/3.0

On 04/29/2010 11:24 AM, Jan Kiszka wrote:
qemu_opts_create duplicates the id we pass in case it shall be stored in
the opts. So we do not need to dup it in qemu_opts_parse, leaking a few
bytes this way.

Signed-off-by: Jan Kiszka<address@hidden>

Applied.  Thanks.

Regards,

Anthony Liguori
---
  qemu-option.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/qemu-option.c b/qemu-option.c
index 1ffc497..076dddf 100644
--- a/qemu-option.c
+++ b/qemu-option.c
@@ -763,10 +763,10 @@ QemuOpts *qemu_opts_parse(QemuOptsList *list, const char 
*params,

      if (strncmp(params, "id=", 3) == 0) {
          get_opt_value(value, sizeof(value), params+3);
-        id = qemu_strdup(value);
+        id = value;
      } else if ((p = strstr(params, ",id=")) != NULL) {
          get_opt_value(value, sizeof(value), p+4);
-        id = qemu_strdup(value);
+        id = value;
      }
      opts = qemu_opts_create(list, id, 1);
      if (opts == NULL)








reply via email to

[Prev in Thread] Current Thread [Next in Thread]