|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [PATCH] virtio-serial: Fix check for 'assert'; prevent NULL derefs |
Date: | Mon, 03 May 2010 12:14:13 -0500 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0pre Thunderbird/3.0 |
On 04/30/2010 06:13 AM, Amit Shah wrote:
In the flush_queued_data() function, we expect port to be valid. Assert only for port and not port || discard. Reported-by: Juan Quintela<address@hidden> Signed-off-by: Amit Shah<address@hidden>
Applied. Thanks. Regards, Anthony Liguori
--- hw/virtio-serial-bus.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c index 97694d5..3ce95e8 100644 --- a/hw/virtio-serial-bus.c +++ b/hw/virtio-serial-bus.c @@ -137,7 +137,7 @@ static void do_flush_queued_data(VirtIOSerialPort *port, VirtQueue *vq, static void flush_queued_data(VirtIOSerialPort *port, bool discard) { - assert(port || discard); + assert(port); do_flush_queued_data(port, port->ovq,&port->vser->vdev, discard); }
[Prev in Thread] | Current Thread | [Next in Thread] |