qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH v7 4/6] char: Add qemu_chr_write_nb() for nonblo


From: Gerd Hoffmann
Subject: [Qemu-devel] Re: [PATCH v7 4/6] char: Add qemu_chr_write_nb() for nonblocking writes
Date: Wed, 05 May 2010 21:16:03 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Thunderbird/3.0.4

On 05/05/10 20:49, Anthony Liguori wrote:
On 05/05/2010 01:43 PM, Gerd Hoffmann wrote:
On 05/05/10 15:53, Anthony Liguori wrote:
This patch adds optional control flow in a pretty crufty way to *some*
backends but not all. This just adds a bunch of complexity that will
certainly introduce bugs.

Amit plans to add support to the others as well. Beside that there is
a clearly defined backup plan: In case the non-blocking interface
isn't supported by $chardev it will fallback to use the blocking mode.

If we have a second interface, we'll have two interfaces forever. I'd
rather see us aggressive remove the blocking interface instead of
introducing a second interface.

I'm all for killing the blocking interface. Problem is that converting over all users isn't exactly trivial and we have plenty of them. IMHO it isn't realistic to do the switch with a single patch series.

cheers,
  Gerd





reply via email to

[Prev in Thread] Current Thread [Next in Thread]