[Qemu-devel] Missing mon in monitor_cur_is_qmp() and qerror_report()

[Jan Kiszka]

Luiz,

I missed this when the API was first proposed:

cur_mon is scheduled for removal (one day...). It's just an intermediate
step to convert all users to explicit 'mon' passing. Thus, new APIs
should not rely it.

I just realized that monitor_cur_is_qmp() does so. It should be
refactored to monitor_is_qmp(Monitor *mon). And qerror should be enhance
by a 'mon' argument as well. Callers that aren't passed a 'mon'
themselves should either be fixed at this chance or could fall back to
cur_mon for the time being.

So far for the theory - do you see any pitfalls in the existing usage?

Jan

signature.asc
Description: OpenPGP digital signature