qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 2/2] reformatted SS-5 and LX definitions


From: Blue Swirl
Subject: [Qemu-devel] Re: [PATCH 2/2] reformatted SS-5 and LX definitions
Date: Sun, 9 May 2010 10:44:46 +0300

On 5/8/10, Artyom Tarasenko <address@hidden> wrote:
> ---
>   hw/sun4m.c |   66 
> ++++++++++++++++++++++++++++++------------------------------
>   1 files changed, 33 insertions(+), 33 deletions(-)

In general, formatting changes cause git blame information loss so
those are not appreciated very much.

In this specific case, I don't see any need to reformat, because the
layout of SS-5 and LX definitions match the surrounding definitions.
One could argue that all definitions should be formatted to match the
longest field (.default_cpu_model), but I still think that it would
not gain much.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]