[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] pci: cleanly backout of pci_qdev_init()
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH] pci: cleanly backout of pci_qdev_init() |
|
Date: |
Tue, 11 May 2010 11:25:16 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Alex Williamson <address@hidden> writes:
> If the init function of a device fails, as might happen with device
> assignment, we never undo the work done by do_pci_register_device().
> This not only causes a bit of a memory leak, but also leaves a bogus
> pointer in the bus devices array that can cause a segfault or
> garbage data from 'info pci'.
>
> Signed-off-by: Alex Williamson <address@hidden>
Looks good to me. Gerd?