[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] target-sparc: Simplify ICC generation; fix
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/3] target-sparc: Simplify ICC generation; fix ADDX carry generation. |
|
Date: |
Wed, 12 May 2010 07:56:12 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-3.fc13 Thunderbird/3.0.4 |
On 05/11/2010 02:31 PM, Artyom Tarasenko wrote:
> Nack. It looks like you reverted carry generation to the previous
> (broken) behavior.
Oh? I suppose I should go back and look at the logs, but the way
it's written there sure seems to match 5.1.5.1 of the sparcv9 manual:
You'll only get carry into the high bit on X - Y if X < Y.
In any case, if you meant to fix carry computation for subtraction,
you missed changing the 64-bit carry computation too. It is still
written the same way before and after my patch, and matches both
the expectation I have from the v9 manual and the post-patch code
along the 32-bit path.
r~
[Qemu-devel] [PATCH 1/3] target-sparc: Fix compilation with --enable-debug., Richard Henderson, 2010/05/10
[Qemu-devel] [PATCH 3/3] target-sparc: Inline some generation of carry for ADDX/SUBX., Richard Henderson, 2010/05/10
[Qemu-devel] [PATCH 0/3] Fix ADDX compilation plus improvements, v2, Richard Henderson, 2010/05/12