[Qemu-devel] Re: Commit 9c9bb6c89d4 breaks code execution from flash

[Jan Kiszka]

Michael Walle wrote:
> Am Wednesday 12 May 2010 09:56:31 schrieb Jan Kiszka:
>> OK, that was a hard nut. After various dead ends, I think I found an
>> possible solution. Can you give this a try?
> [..]
>> Still requires proper patch split up, and I need to think about possible
>> side effects.
> Thanks, the patch is working.

Unfortunately, now that resetting the mode on read is fixed, my whole
optimization does not work any, writing to flash takes decades again.
Back to the drawing board...

> 
> But i noticed another minor bug. The cfi02 doesn't handle 'read flash id' on 
> 16bit accesses correctly. It always returns 8 bit. I used something like
> 
> if (width == 2)
>     ret = pfl->ident[0] << 8 | pfl->ident[1];  /* rsp. ident[1]/ident[2] */
> 
> within the 0x90 reading as a quick workaround.

Are you sure that this is valid? The whole cfi_table is also only
provided byte-wise, same in cfi01.

Jan

signature.asc
Description: OpenPGP digital signature