|
From: | Paolo Bonzini |
Subject: | [Qemu-devel] Re: Another SIGFPE in display code, now in cirrus |
Date: | Thu, 13 May 2010 09:36:47 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.4 |
On 05/12/2010 05:57 PM, Stefano Stabellini wrote:
I guess even a src blt pitch of 0 could be useful there, however in practice I think the only rop function that was written with this case in mind has: dstpitch -= bltwidth; srcpitch -= bltwidth; if (dstpitch< 0 || srcpitch< 0) { /* is 0 valid? srcpitch == 0 could be useful */ return; }
Note that here srcpitch == 0 is actually srcpitch == bltwidth, which _is_ obviously useful.
The "real" srcpitch == 0 case would result in srcpitch == -bltwidth, and it is actually quite useful if you want to stretch a Nx1 bitmap to NxN.
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |