On 05/12/2010 04:38 PM, Jes Sorensen wrote:
On 05/12/10 22:29, Cole Robinson wrote:
Commit f75ca1ae205f24dae296c82d534c37746f87232f changed the version
string from:
QEMU PC Emulator version x.yy.z
to
QEMU Emulator version x.yy.z
libvirt is overly sensitive to the format of this string, and barfs when
trying to parse qemu -help output. While libvirt should certainly be more
robust here, changing the output format of -version for cosmetic reasons
doesn't seem like the best idea, so let's revert the change and add a
comment explaining the issue.
Rather than this, I would prefer a -version argument that just returns
the current QEMU version string.
IMHO it's not a good approach to do static string matching.
I agree libvirt's method is a crappy approach. Adding a proper -version
argument is certainly the way forward, but doesn't help users with
existing libvirt installations that want to use latest qemu. This is the
type of issue that libvirt devs will be fielding for months. Ideally i'd
like the order to be:
1) Apply this patch
2) Add a proper -version argument, maybe named -version_num
3) libvirt patched to use new version argument (and robustify legacy
version parsing)
4) Some reasonable amount of time from now (6 months, a year?), edit the
current -version string at will
I'd be willing to do 2 and 3 if people agree.