Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

[Avi Kivity]

On 05/14/2010 11:50 AM, Markus Armbruster wrote:
> > > +
> > > +{ "execute": "migrate_set_speed", "arguments": { "value": 1024 } }
> > >
> > >        
> > Oh, we do have more.
> >
> > Please document the units for this value (bits per second)?
> >      
> bytes per second?
>    

Bandwidth is typically measured in bits per second.

> > > +- "bus": identical to the parent's bus number (json-int)
> > > +- "slot": slot number (json-int)
> > > +- "function": function number (json-int)
> > >
> > >        
> > Would have been nicer as a nested object (list of buses, each
> > containing a list of slots, each containing a list of functions).
> >      
> We have a list of buses, each containing a list of device functions.
> Not sure the additional level of nesting you propose buys us anything.
>    

A slot is the hotpluggable entity.  Open your computer and you can 
actually see them.

btw would be good to list empty slots as well.

What about PCI domains?

--
Do not meddle in the internals of kernels, for they are subtle and quick to 
panic.