[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

[Avi Kivity]

On 05/14/2010 12:10 AM, Cam Macdonell wrote:
> On Mon, May 10, 2010 at 5:59 AM, Avi Kivity<address@hidden>  wrote:
>    
> > On 04/21/2010 08:53 PM, Cam Macdonell wrote:
> >      
>    
> > > +
> > > +        /* allocate/initialize space for interrupt handling */
> > > +        s->eventfds = qemu_mallocz(s->nr_alloc_guests * sizeof(int *));
> > > +        s->eventfd_table = qemu_mallocz(s->vectors *
> > > sizeof(EventfdEntry));
> > > +        s->eventfds_posn_count = qemu_mallocz(s->nr_alloc_guests *
> > > sizeof(int));
> > > +
> > > +        pci_conf[PCI_INTERRUPT_PIN] = 1; /* we are going to support
> > > interrupts */
> > >
> > >        
> > This is done by the guest BIOS.
> >
> >
> >      
> If I remove that line, my driver crashes when it falls back to
> pin-based interrupts (when MSI is turned off).  Is there something in
> the device driver that I need to set in place of this?  A number of
> other devices (mostly network cards) set the interrupt pin this way,
> so I'm a little confused.
>    

Sorry, I confused this with PCI_INTERRUPT_LINE.

Note there is a helper to set it, pci_config_set_interrupt_pin().

--
Do not meddle in the internals of kernels, for they are subtle and quick to 
panic.