Re: [Qemu-devel] [PATCH] My patches

[Andreas Färber]

Hello,

Am 16.05.2010 um 18:19 schrieb C.W. Betts:

> These are my following patches to contribute to Qemu.
> Included in the patch:
> * ignore missing libuuid on Darwin: libSystem has the needed  
> functions in it.
> * quiet warning about no prototype for qemu_main when building Cocoa.
> * fixes handleEvent: warning in Cocoa.m
> * use <> other than "" in qemu-thread.h for system includes.
>
> <gitdiff.diff>

Could you please resubmit as multiple inline git-send-email patches,  
with full explanations and Signed-off-by?

Briefly looking at it, you seem to have tackled the v10.6 handleEvent  
issue differently from Juha - they created a separate qemuHandleEvent  
function with void return iirc. Did you test yours with v10.5 or below?

The qemu_main prototype fix looks better than in John's patch, but  
iirc there'd be a duplicate in cocoa.m - I think having it in a header  
rather than in vl.c and cocoa.m would be even better.

What does the cpu-all.h change fix?

And on the topic of warnings, has anyone already looked into the  
deprecation warnings from the audio code?

Thanks,
Andreas