[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH 01/10] vnc: refactor set_encodings
|
From: |
Corentin Chary |
|
Subject: |
Re: [Qemu-devel] Re: [PATCH 01/10] vnc: refactor set_encodings |
|
Date: |
Tue, 18 May 2010 11:56:40 +0200 |
On Tue, May 18, 2010 at 11:18 AM, Alexander Graf <address@hidden> wrote:
>
> On 18.05.2010, at 09:31, Corentin Chary wrote:
>
> This is missing a patch description. When people later on either cherry-pick
> your commits or simply git show them, it's almost impossible to know what's
> going on.
> So please always put in a patch description.
>
>
> Alex
>
In this case, the description is all in the subject and the patch is
pretty obvious.
Should I really add something like "Create a new set_encoding()
function to remove duplicate code in set_encodings()." ?
--
Corentin Chary
http://xf.iksaif.net
- [Qemu-devel] [PATCH 10/10] vnc: update copyrights for vnc-encoding-tight.c, (continued)
- [Qemu-devel] [PATCH 10/10] vnc: update copyrights for vnc-encoding-tight.c, Corentin Chary, 2010/05/18
- [Qemu-devel] [PATCH 09/10] vnc: tight: add palette encoding, Corentin Chary, 2010/05/18
- [Qemu-devel] [PATCH 08/10] vnc: remove memory leaks in zlib and tight encoding, Corentin Chary, 2010/05/18
- [Qemu-devel] [PATCH 05/10] vnc: add basic tight support, Corentin Chary, 2010/05/18
- [Qemu-devel] [PATCH 06/10] vnc: add support for tight fill encoding, Corentin Chary, 2010/05/18
- [Qemu-devel] [PATCH 03/10] vnc: only use a single zlib stream, Corentin Chary, 2010/05/18
- [Qemu-devel] [PATCH 04/10] vnc: adjust compression zstream level, Corentin Chary, 2010/05/18
- [Qemu-devel] [PATCH 02/10] vnc: really call zlib if we want zlib, Corentin Chary, 2010/05/18
- [Qemu-devel] [PATCH 01/10] vnc: refactor set_encodings, Corentin Chary, 2010/05/18
- [Qemu-devel] Re: [PATCH 01/10] vnc: refactor set_encodings, Alexander Graf, 2010/05/18