[Qemu-devel] Re: [PATCH v2 01/10] vnc: refactor set_encodings

[Alexander Graf]

On 18.05.2010, at 20:09, Corentin Chary wrote:

> On Tue, May 18, 2010 at 2:54 PM, Alexander Graf <address@hidden> wrote:
>> Corentin Chary wrote:
>>> Create a new set_encoding() function to remove
>>> duplicated code in set_encodings().
>>> 
>>> Signed-off-by: Corentin Chary <address@hidden>
>>> 
>> 
>> Acked-by: Alexander Graf <address@hidden>
>> 
>> Keep in mind that this still means that the last requested compression
>> algorithm is used, which is reverse according to spec.
>> 
> 
> I didn't notice that the loop was reversed, and that the right
> encoding was selected *before* my patch.
> I think the right thing to do is to reverse my previous patch and add
> a comment at the begining of the loop.

I don't see your patch reversing the logic?

Alex