[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 2/3] QMP: Introduce commands documentation
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] Re: [PATCH 2/3] QMP: Introduce commands documentation |
Date: |
Wed, 19 May 2010 10:55:27 -0300 |
On Wed, 19 May 2010 15:50:56 +0200
Jan Kiszka <address@hidden> wrote:
> Luiz Capitulino wrote:
> > On Wed, 19 May 2010 15:30:43 +0200
> > Jan Kiszka <address@hidden> wrote:
> >
> >> Luiz Capitulino wrote:
> >
> > [...]
> >
> >>> I didn't submit the syntax checking bits on purpose, there's something
> >>> failing there and I didn't want to check it now.
> >> You already did for QMP, just skipped the STEXI/ETEXI balancing checks.
> >> And if that reports an error for TEXI, better have a closer look. It
> >> worked fine with my tree, so something may have regressed.
> >
> > Here you go:
> >
> > """
> > GEN qemu-img-cmds.texi
> > line 10: syntax error: expected ETEXI, found STEXI
> > make: *** [qemu-img-cmds.texi] Error 1
> > make: *** Deleting file `qemu-img-cmds.texi'
> > """
> >
> > Indeed, looks like a bug in qemu-img-cmds.hx:
> >
> > """
> > STEXI
> > @table @option
> > STEXI
> > """
>
> Oh, then I also did no "make clean all" run with my patch applied that
> night... :] Still, good to know that it works. I can handle this if you
> don't want to.
Please do, you could send both patches in the same series (ie. fix and
feature), so that we don't break the build.
[Qemu-devel] [PATCH 3/3] Monitor: Drop QMP documentation from code, Luiz Capitulino, 2010/05/18
[Qemu-devel] Re: [PATCH v3 0/3]: QMP: Commands doc, Jan Kiszka, 2010/05/29