Re: [Qemu-devel] [PATCH 1/3] Fix %lld or %llx printf format use

[Blue Swirl]

On 5/17/10, Markus Armbruster <address@hidden> wrote:
> Blue Swirl <address@hidden> writes:
>
>  > Signed-off-by: Blue Swirl <address@hidden>
>  > ---
>  >  audio/audio_template.h  |    2 +-
>  >  block/curl.c            |    9 ++++---
>  >  block/parallels.c       |    7 ++++-
>  >  block/qcow2.c           |    8 ++++--
>  >  darwin-user/commpage.c  |    2 +-
>  >  darwin-user/syscall.c   |    2 +-
>  >  hw/vga.c                |    2 +-
>  >  hw/vhost_net.c          |    2 +-
>  >  ia64-dis.c              |    9 +++++--
>  >  nbd.c                   |    4 +-
>  >  qemu-img.c              |   10 ++++----
>  >  qemu-io.c               |   57 
> ++++++++++++++++++++++++-----------------------
>  >  target-cris/translate.c |    4 +-
>  >  target-ppc/translate.c  |    7 +++--
>  >  target-sparc/helper.c   |    2 +-
>  >  15 files changed, 69 insertions(+), 58 deletions(-)
>  >
>  > diff --git a/audio/audio_template.h b/audio/audio_template.h
>  > index 6b19848..2f5224b 100644
>  > --- a/audio/audio_template.h
>  > +++ b/audio/audio_template.h
>  > @@ -541,7 +541,7 @@ uint64_t glue (AUD_get_elapsed_usec_, TYPE) (SW
>  > *sw, QEMUAudioTimeStamp *ts)
>  >
>  >      cur_ts = sw->hw->ts_helper;
>  >      old_ts = ts->old_ts;
>  > -    /* dolog ("cur %lld old %lld\n", cur_ts, old_ts); */
>  > +    /* dolog ("cur %" PRId64 " old %" PRId64 "\n", cur_ts, old_ts); */
>  >
>  >      if (cur_ts >= old_ts) {
>  >          delta = cur_ts - old_ts;
>  > diff --git a/block/curl.c b/block/curl.c
>  > index b944740..94b451c 100644
>  > --- a/block/curl.c
>  > +++ b/block/curl.c
>  > @@ -118,7 +118,7 @@ static size_t curl_read_cb(void *ptr, size_t size,
>  > size_t nmemb, void *opaque)
>  >      size_t realsize = size * nmemb;
>  >      int i;
>  >
>  > -    DPRINTF("CURL: Just reading %lld bytes\n", (unsigned long 
> long)realsize);
>  > +    DPRINTF("CURL: Just reading %" PRId64 " bytes\n", (uint64_t)realsize);
>  >
>  >      if (!s || !s->orig_buf)
>  >          goto read_end;
>
>
> realsize is size_t.  Why don't you print it as such?  Same issue
>  elsewhere.
>
>  [...]
>

Thanks for the review. I'll send an updated version.