[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_c
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_compare |
Date: |
Thu, 20 May 2010 10:50:38 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Thunderbird/3.0.4 |
Am 19.05.2010 20:53, schrieb Christoph Hellwig:
> The difference between the start sectors of two requests can be larger
> than the size of the "int" type, which can lead to a not correctly
> sorted multiwrite array and thus spurious I/O errors and filesystem
> corruption due to incorrect request merges.
>
> So instead of doing the cute sector arithmetics trick spell out the
> exact comparisms.
>
> Spotted by Kevin Wolf based on a testcase from Michael Tokarev.
>
> Signed-off-by: Christoph Hellwig <address@hidden>
Thanks, applied to the block branch.
Kevin
- [Qemu-devel] [PATCH] block: fix sector comparism in multiwrite_req_compare, Christoph Hellwig, 2010/05/19
- [Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_compare, Michael Tokarev, 2010/05/19
- [Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_compare, Christoph Hellwig, 2010/05/19
- [Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_compare, Michael Tokarev, 2010/05/19
- Re: [Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_compare, Kevin Wolf, 2010/05/19
- Re: [Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_compare, Avi Kivity, 2010/05/20
- Re: [Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_compare, Kevin Wolf, 2010/05/20
- Re: [Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_compare, Avi Kivity, 2010/05/20
[Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_compare,
Kevin Wolf <=