qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 04/22] tcg-i386: Tidy ext8s and ext16s operation


From: Aurelien Jarno
Subject: Re: [Qemu-devel] [PATCH 04/22] tcg-i386: Tidy ext8s and ext16s operations.
Date: Thu, 20 May 2010 20:52:25 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

On Tue, Apr 13, 2010 at 04:13:49PM -0700, Richard Henderson wrote:
> Define OPC_MOVSBL and OPC_MOVSWL.  Factor opcode emission to
> separate functions.  Don't restrict the input register to the
> low 4 "q" registers; emit shifts instead if needed.
>

Given this patch is of the same type as the previous one, I have also
benchmarked it, here are the results:

        |  instr |  size  |
        +--------+--------+
 before | 101258 | 344829 |
 after  | 101258 | 344833 |
 
This time the patch clearly doesn't bring an improvement, so I think it
should also be rewritten without the constraints change.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net



reply via email to

[Prev in Thread] Current Thread [Next in Thread]