Re: [Qemu-devel] [PATCH 12/22] tcg-i386: Tidy movi.

[Aurelien Jarno]

On Wed, Apr 14, 2010 at 10:20:08AM -0700, Richard Henderson wrote:
> Define and use OPC_MOVL_Iv.
> 
> Signed-off-by: Richard Henderson <address@hidden>

Acked-by: Aurelien Jarno <address@hidden>

> ---
>  tcg/i386/tcg-target.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c
> index b4e8e74..06946e5 100644
> --- a/tcg/i386/tcg-target.c
> +++ b/tcg/i386/tcg-target.c
> @@ -178,6 +178,7 @@ static inline int tcg_target_const_match(tcg_target_long 
> val,
>  #define OPC_MOVB_EvGv        (0x88)          /* stores, more or less */
>  #define OPC_MOVL_EvGv        (0x89)          /* stores, more or less */
>  #define OPC_MOVL_GvEv        (0x8b)          /* loads, more or less */
> +#define OPC_MOVL_Iv     (0xb8)
>  #define OPC_MOVZBL   (0xb6 | P_EXT)
>  #define OPC_MOVZWL   (0xb7 | P_EXT)
>  #define OPC_MOVSBL   (0xbe | P_EXT)
> @@ -305,7 +306,7 @@ static inline void tcg_out_movi(TCGContext *s, TCGType 
> type,
>      if (arg == 0) {
>          tgen_arithr(s, ARITH_XOR, ret, ret);
>      } else {
> -        tcg_out8(s, 0xb8 + ret);
> +        tcg_out8(s, OPC_MOVL_Iv + ret);
>          tcg_out32(s, arg);
>      }
>  }
> -- 
> 1.6.6.1
> 
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net