Re: [Qemu-devel] [PATCH 15/22] tcg-i386: Tidy ret.

[Aurelien Jarno]

On Wed, Apr 14, 2010 at 11:04:14AM -0700, Richard Henderson wrote:
> Define and use OPC_RET.
> 
> Signed-off-by: Richard Henderson <address@hidden>

Acked-by: Aurelien Jarno <address@hidden>

> ---
>  tcg/i386/tcg-target.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c
> index e82788d..27e9e9e 100644
> --- a/tcg/i386/tcg-target.c
> +++ b/tcg/i386/tcg-target.c
> @@ -188,6 +188,7 @@ static inline int tcg_target_const_match(tcg_target_long 
> val,
>  #define OPC_PUSH_r32 (0x50)
>  #define OPC_PUSH_Iv  (0x68)
>  #define OPC_PUSH_Ib  (0x6a)
> +#define OPC_RET              (0xc3)
>  #define OPC_SHIFT_1  (0xd1)
>  #define OPC_SHIFT_Ib (0xc1)
>  #define OPC_SHIFT_cl (0xd3)
> @@ -1426,7 +1427,7 @@ void tcg_target_qemu_prologue(TCGContext *s)
>      for(i = ARRAY_SIZE(tcg_target_callee_save_regs) - 1; i >= 0; i--) {
>          tcg_out_pop(s, tcg_target_callee_save_regs[i]);
>      }
> -    tcg_out8(s, 0xc3); /* ret */
> +    tcg_out_opc(s, OPC_RET);
>  }
>  
>  void tcg_target_init(TCGContext *s)
> -- 
> 1.6.6.1
> 
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net