[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] arm_timer: fix oneshot mode
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] arm_timer: fix oneshot mode |
Date: |
Fri, 21 May 2010 12:00:49 +0200 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Sun, May 02, 2010 at 03:20:52PM +0530, Rabin Vincent wrote:
> In oneshot mode, the delta needs to come from the TimerLoad register,
> not the maximum limit.
>
> Signed-off-by: Rabin Vincent <address@hidden>
Thanks, applied.
> ---
> hw/arm_timer.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/arm_timer.c b/hw/arm_timer.c
> index 5b6947a..9073ffc 100644
> --- a/hw/arm_timer.c
> +++ b/hw/arm_timer.c
> @@ -71,7 +71,7 @@ static void arm_timer_recalibrate(arm_timer_state *s, int
> reload)
> {
> uint32_t limit;
>
> - if ((s->control & TIMER_CTRL_PERIODIC) == 0) {
> + if ((s->control & (TIMER_CTRL_PERIODIC | TIMER_CTRL_ONESHOT)) == 0) {
> /* Free running. */
> if (s->control & TIMER_CTRL_32BIT)
> limit = 0xffffffff;
> --
> 1.7.0.4
>
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net