[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] hxtool: Add syntax error detection
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] hxtool: Add syntax error detection |
Date: |
Sat, 22 May 2010 09:27:12 +0000 |
Thanks, applied.
On Thu, May 20, 2010 at 7:16 AM, Jan Kiszka <address@hidden> wrote:
> From: Jan Kiszka <address@hidden>
>
> Add basic imbalance detection for STEXT/ETEXI.
>
> Signed-off-by: Jan Kiszka <address@hidden>
> ---
> hxtool | 16 +++++++++++++++-
> 1 files changed, 15 insertions(+), 1 deletions(-)
>
> diff --git a/hxtool b/hxtool
> index 0fdbc64..8f65532 100644
> --- a/hxtool
> +++ b/hxtool
> @@ -19,11 +19,24 @@ hxtoh()
> hxtotexi()
> {
> flag=0
> + line=1
> while read -r str; do
> case "$str" in
> HXCOMM*)
> ;;
> - STEXI*|ETEXI*) flag=$(($flag^1))
> + STEXI*)
> + if test $flag -eq 1 ; then
> + echo "line $line: syntax error: expected ETEXI, found $str"
> >&2
> + exit 1
> + fi
> + flag=1
> + ;;
> + ETEXI*)
> + if test $flag -ne 1 ; then
> + echo "line $line: syntax error: expected STEXI, found $str"
> >&2
> + exit 1
> + fi
> + flag=0
> ;;
> DEFHEADING*)
> echo "$(expr "$str" : "DEFHEADING(\(.*\))")"
> @@ -32,6 +45,7 @@ hxtotexi()
> test $flag -eq 1 && echo "$str"
> ;;
> esac
> + line=$((line+1))
> done
> }
>
> --
> 1.6.0.2
>
>