[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 08/15] Add base64 encoder/decoder
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH v2 08/15] Add base64 encoder/decoder |
Date: |
Sun, 23 May 2010 12:04:42 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Avi Kivity wrote:
> On 05/23/2010 10:55 AM, Jan Kiszka wrote:
>>>> +/*
>>>> + * Convert string 'src' of length 'srclen' from base64 to binary form,
>>>> + * saving the result in 'dest'. The size of the destination buffer
>>>> must be at
>>>> + * least srclen * 3 / 4.
>>>> + *
>>>> + * Returns 0 on success, -1 on conversion error.
>>>> + */
>>>> +int base64_decode(const char *src, size_t srclen, void *dest)
>>>>
>>> I think dest should be char *, like all the functions where dest is
>>> passed to.
>>>
>> The output may but need not be a string, it's binary data. And to avoid
>> needless warnings about signedness mismatches if unsigned char or
>> uint8_t buffers are passed, I chose void *.
>>
>
> I think qemu is pretty consistent in using uint8_t for binary, and void
> * is a little dangerous as it allows passing any kind of data (anything
> above a byte is subject to endianness issues for example).
>
> But I don't feel strongly about this.
>
Let's go for consistency: I switched to uint8_t for the binary input/output.
Jan
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v2 04/15] qdev: Convert device and bus lists to QTAILQ, Jan Kiszka, 2010/05/22
[Qemu-devel] [PATCH v2 05/15] qdev: Allow device specification by qtree path for device_del, Jan Kiszka, 2010/05/22
[Qemu-devel] [PATCH v2 07/15] monitor: Add completion for qdev paths, Jan Kiszka, 2010/05/22
[Qemu-devel] [PATCH v2 11/15] monitor: return length of printed string via monitor_[v]printf, Jan Kiszka, 2010/05/22
[Qemu-devel] [PATCH v2 09/15] QMP: Reserve namespace for complex object classes, Jan Kiszka, 2010/05/22
[Qemu-devel] [PATCH v2 10/15] Add QBuffer, Jan Kiszka, 2010/05/22
[Qemu-devel] [PATCH v2 15/15] QMP: Add support for buffer class to qmp python helper, Jan Kiszka, 2010/05/22
[Qemu-devel] [PATCH v2 12/15] monitor: Add basic device state visualization, Jan Kiszka, 2010/05/22