Re: [Qemu-devel] [PATCH, RFC 3/4] Implement byte swapped MMIO type

[Igor Kovalenko]

On Mon, May 24, 2010 at 12:34 AM, Blue Swirl <address@hidden> wrote:
> BROKEN
>
> Signed-off-by: Blue Swirl <address@hidden>
> ---
>  cpu-common.h       |    3 +-
>  softmmu_template.h |   69 
> ++++++++++++++++++++++++++++++++++++++++++++++------
>  2 files changed, 63 insertions(+), 9 deletions(-)

Changes to io_read and io_write seem to have issue with considering
wrong value bits, you should check physaddr instead since index is cut
off physaddr.

It's probably a good idea to instead do a byteswap at __ld*/__st*
level (a bit higher level than in your change.)
These two sets are directly entered from runtime, and this way you
need only two templates changed.
Not sure if it is a good idea to handle unaligned accesses.

-- 
Kind regards,
Igor V. Kovalenko