qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qdev-properties: Fix (u)intXX parsers


From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH] qdev-properties: Fix (u)intXX parsers
Date: Wed, 26 May 2010 13:19:37 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Thunderbird/3.0.4

Am 26.05.2010 13:13, schrieb Markus Armbruster:
> Kevin Wolf <address@hidden> writes:
> 
>> scanf calls must not use PRI constants, they have probably the wrong size and
>> corrupt memory. We could replace them by SCN ones, but strtol is simpler than
>> scanf here anyway. While at it, also fix the parsers to reject garbage after
>> the number ("4096xyz" was accepted before).
> 
> Do we have more misuse of PRI with scanf elsewhere?  No need to fix them
> all in one commit (and thus delay this fix); I just want to make sure
> somebody looks.

I saw another one in some Xen file that Gerd should fix some time. I'm
not aware of any other.

Kevin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]