[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: hw/serial.c: Xmit fifo never used
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] Re: hw/serial.c: Xmit fifo never used |
Date: |
Wed, 26 May 2010 12:42:44 +0100 |
User-agent: |
Alpine 2.00 (DEB 1167 2008-08-23) |
On Wed, 26 May 2010, Jan Kiszka wrote:
> Frank Mehnert wrote:
> > On Wednesday 26 May 2010, Jan Kiszka wrote:
> >> Frank Mehnert wrote:
> >>> I assume the correct condition would be '>= 0', that is
> >>>
> >>> ...
> >>> if ((s->tsr_retry >= 0) && (s->tsr_retry <= MAX_XMIT_RETRY)) {
> >>> s->tsr_retry++;
> >>> ...
> >> Makes sense, patch welcome.
> >
> > Attached.
>
> Signed-off, subject, and description please. And I would keep Stefano as
> the original author of this feature in CC. A cross-check by him might be
> good as we enable a code path that was apparently dead so far.
>
I think the patch is correct.
Re: [Qemu-devel] hw/serial.c: Xmit fifo never used, Paul Brook, 2010/05/28