[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] vhost_net.c: v2 Fix build failure introduced by
From: |
Jes Sorensen |
Subject: |
[Qemu-devel] Re: [PATCH] vhost_net.c: v2 Fix build failure introduced by 0bfcd599e3f5c5679cc7d0165a0a1822e2f60de2 |
Date: |
Thu, 27 May 2010 13:04:27 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Lightning/1.0b2pre Thunderbird/3.0.4 |
On 05/27/10 12:54, Michael S. Tsirkin wrote:
> On Thu, May 27, 2010 at 12:55:49PM +0200, Jes Sorensen wrote:
>> On 05/27/10 12:44, Michael S. Tsirkin wrote:
>>> On Thu, May 27, 2010 at 12:22:29PM +0200, address@hidden wrote:
>>>> From: Jes Sorensen <address@hidden>
>>>>
>>>> Fix build failure introduced by 0bfcd599e3f5c5679cc7d0165a0a1822e2f60de2
>>>>
>>>> The format statement expects unsigned long on x86_64, but receives
>>>> unsigned long long, so gcc exits with an error.
>>>>
>>>> Signed-off-by: Jes Sorensen <address@hidden>
>>>
>>> I think this part of 0bfcd599e3f5c5679cc7d0165a0a1822e2f60de2
>>> should just be reverted. We have unsigned long, it should be printed
>>> woith %ll. Casting to uint64_t just so we can print with PRIu64 seems silly.
>>
>> That is an option too.
>
> More importantly does this fix the problem for you?
Yes it works fine.
Acked-by: Jes Sorensen <address@hidden>