[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] posix-aio-compat: Expand tabs that have crept i
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] posix-aio-compat: Expand tabs that have crept in |
Date: |
Thu, 27 May 2010 14:12:33 +0100 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Thu, May 27, 2010 at 02:50:54PM +0200, Kevin Wolf wrote:
> I'm usually not a big supporter of patches that only change style, but
> tabs are nasty and you can ignore these whitespace changes in git blame
> at least, so for all I care let's take it for once.
Interesting, I tend to prefer separate code change and whitespace change
patches. It's hard to review a patch that combines code and whitespace
changes because you have to manually compare the touched lines to see
what, if anything, has changed.
Is this the policy across all of QEMU or your preference for
block-related code? I'll try to follow it for that area in the future.
Thanks,
Stefan