[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 0/4] Cleanups for block code
From: |
Jes . Sorensen |
Subject: |
[Qemu-devel] [PATCH 0/4] Cleanups for block code |
Date: |
Thu, 27 May 2010 16:20:29 +0200 |
From: Jes Sorensen <address@hidden>
Hi,
Reading through some of the blk code, I noticed a lot of cases where
we mix and match between hard-coded values for the block size of 512
and using BDRV_SECTOR_SIZE. Trying to clean it up a bit and change the
512 constants to BDRV_SECTOR_SIZE as it is more explaning when reading
the code.
In addition it fixes up a case in bdrv_open where we did the division,
just to multiply back to the original value for no real reason.
Cheers,
Jes
Jes Sorensen (4):
Cleanup: bdrv_open() no need to shift total_size just to shift back.
Cleanup: Be consistent and use BDRV_SECTOR_SIZE instead of 512
Cleanup: raw-posix.c: Be more consistent using BDRV_SECTOR_SIZE
instead of 512
Cleanup: virtio-blk.c: Be more consistent using BDRV_SECTOR_SIZE
instead
block.c | 17 +++++++++--------
block/raw-posix.c | 20 +++++++++++---------
hw/virtio-blk.c | 7 ++++---
3 files changed, 24 insertions(+), 20 deletions(-)
- [Qemu-devel] [PATCH 0/4] Cleanups for block code,
Jes . Sorensen <=
- [Qemu-devel] [PATCH 2/4] Cleanup: Be consistent and use BDRV_SECTOR_SIZE instead of 512, Jes . Sorensen, 2010/05/27
- [Qemu-devel] [PATCH 1/4] Cleanup: bdrv_open() no need to shift total_size just to shift back., Jes . Sorensen, 2010/05/27
- [Qemu-devel] [PATCH 4/4] Cleanup: virtio-blk.c: Be more consistent using BDRV_SECTOR_SIZE instead, Jes . Sorensen, 2010/05/27
- [Qemu-devel] [PATCH 3/4] Cleanup: raw-posix.c: Be more consistent using BDRV_SECTOR_SIZE instead of 512, Jes . Sorensen, 2010/05/27
- Re: [Qemu-devel] [PATCH 0/4] Cleanups for block code, Kevin Wolf, 2010/05/28