[Qemu-devel] Re: [PATCH v4 0/10] Introduce 'info netdevices' with QMP support

[Luiz Capitulino]

On Tue, 18 May 2010 14:07:39 -0300
Miguel Di Ciurcio Filho <address@hidden> wrote:

> The VLANClientState structure has the member info_str, a simple string that
> is filled with information about NIC devices and used on monitor calls.
> 
> There is no coherent formatting of this string by all the NIC devices,
> making it difficult to parse and represent this information over QMP.
> 
> To make the transition to QMP safe, we leave the current 'info network' 
> command
> as is, and introduce a new one: 'info netdevices'.

 Sorry for the long delay in reviewing this series..

 Most important comment is: QMP development process is changing and now
it's required that any protocol change updates the qemu-monitor.hx file
with QMP info.

 However, it's not merged yet so you could base your series on top of
this series, which is also in my master branch:

http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg01605.html

 Another option is to send the doc patch separately w/o any code and
only go back to code when there's consensus wrt new command.

 Small comments on separate patches follow.