[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH v3 10/17] QMP: Reserve namespace for complex obj
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] Re: [PATCH v3 10/17] QMP: Reserve namespace for complex object classes |
Date: |
Thu, 27 May 2010 17:08:03 -0300 |
On Sun, 23 May 2010 12:59:23 +0200
Jan Kiszka <address@hidden> wrote:
> From: Jan Kiszka <address@hidden>
>
> This reserves JSON objects that contain the key '__class__' for QMP-specific
> complex objects. First user will be the buffer class.
>
> Signed-off-by: Jan Kiszka <address@hidden>
> ---
> QMP/qmp-spec.txt | 16 +++++++++++++---
> 1 files changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/QMP/qmp-spec.txt b/QMP/qmp-spec.txt
> index 9d30a8c..fa1dd62 100644
> --- a/QMP/qmp-spec.txt
> +++ b/QMP/qmp-spec.txt
> @@ -146,6 +146,15 @@ The format is:
> For a listing of supported asynchronous events, please, refer to the
> qmp-events.txt file.
>
> +2.6 Complex object classes
> +--------------------------
> +
> +JSON objects that contain the key-value pair '"__class__": json-string' are
I'm not strong about this, but it's better to call it just a 'pair', as 'value'
is a bit problematic because of json-value.
> +reserved for QMP-specific complex object classes that. QMP specifies which
Early full stop?
> +further keys each of these objects include and how they are encoded.
> +
> +So far, no complex object class is specified.
> +
> 3. QMP Examples
> ===============
>
> @@ -229,9 +238,10 @@ avoid modifying QMP. Both upstream and downstream need
> to take care to
> preserve long-term compatibility and interoperability.
>
> To help with that, QMP reserves JSON object member names beginning with
> -'__' (double underscore) for downstream use ("downstream names"). This
> -means upstream will never use any downstream names for its commands,
> -arguments, errors, asynchronous events, and so forth.
> +'__' (double underscore) for downstream use ("downstream names"). Downstream
> +names MUST NOT end with '__' as this pattern is reserved for QMP-defined JSON
> +object classes. Upstream will never use any downstream names for its
> +commands, arguments, errors, asynchronous events, and so forth.
Suggest mentioning subsection 2.6.
>
> Any new names downstream wishes to add must begin with '__'. To
> ensure compatibility with other downstreams, it is strongly
- [Qemu-devel] Re: [PATCH v3 13/17] monitor: Allow to exclude commands from QMP, (continued)
[Qemu-devel] [PATCH v3 12/17] monitor: return length of printed string via monitor_[v]printf, Jan Kiszka, 2010/05/23
[Qemu-devel] [PATCH v3 16/17] QMP: Fix python helper /wrt long return strings, Jan Kiszka, 2010/05/23
[Qemu-devel] [PATCH v3 10/17] QMP: Reserve namespace for complex object classes, Jan Kiszka, 2010/05/23
- [Qemu-devel] Re: [PATCH v3 10/17] QMP: Reserve namespace for complex object classes,
Luiz Capitulino <=
[Qemu-devel] [PATCH v3 14/17] monitor: Add basic device state visualization, Jan Kiszka, 2010/05/23
[Qemu-devel] [PATCH v3 17/17] QMP: Add support for buffer class to qmp python helper, Jan Kiszka, 2010/05/23