qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH] block.h: Make BDRV_SECTOR_SIZE 64 bit safe


From: Paolo Bonzini
Subject: [Qemu-devel] Re: [PATCH] block.h: Make BDRV_SECTOR_SIZE 64 bit safe
Date: Fri, 28 May 2010 10:32:58 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-3.fc13 Lightning/1.0b2pre Thunderbird/3.0.4

On 05/27/2010 05:44 PM, Jes Sorensen wrote:
>  Candidate for stable too?
It should be safe to apply, but I didn't find any current users where
the mask was applied in a way where it was causing problems. Not sure if
you want the noise, or apply it as better safe than sorry?

The only use in fact is this:

        addr = qemu_get_be64(f);
        flags = addr & ~BDRV_SECTOR_MASK;

which is safe since the ~~ cancels to give back 511 again. So nevermind, just asking. If there are no bugs related to it it seems just as safe not to apply it.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]