[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [SeaBIOS] SMBIOS strings
From: |
Gleb Natapov |
Subject: |
[Qemu-devel] Re: [SeaBIOS] SMBIOS strings |
Date: |
Fri, 28 May 2010 18:44:02 +0300 |
On Fri, May 28, 2010 at 05:24:47PM +0200, Jes Sorensen wrote:
> I guess the Socket Designation in particular might have been done for a
> reason?
>
It was part of commit cf2affa6de. And was a result of moving to
snprintf() instead of direct string manipulation. Before that
string was created like that:
memcpy((char *)start, "CPU " "\0" "" "\0" "", 7);
((char *)start)[4] = cpu_number + '0';
Which start to produce strange cpu numbers for cpus greater then 9. I
doubt we want to go back to that ;)
--
Gleb.