[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] musicpal: Drop redundant reset call
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH] musicpal: Drop redundant reset call |
Date: |
Fri, 28 May 2010 21:49:06 +0200 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Thu, May 13, 2010 at 03:09:58PM +0200, Jan Kiszka wrote:
> Reset is now triggered after init, no need for explicit calls anymore.
Thanks, applied.
> Signed-off-by: Jan Kiszka <address@hidden>
> ---
> hw/musicpal.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/hw/musicpal.c b/hw/musicpal.c
> index ebd933e..d44c5a0 100644
> --- a/hw/musicpal.c
> +++ b/hw/musicpal.c
> @@ -1295,8 +1295,6 @@ static int musicpal_gpio_init(SysBusDevice *dev)
> musicpal_gpio_writefn, s);
> sysbus_init_mmio(dev, MP_GPIO_SIZE, iomemtype);
>
> - musicpal_gpio_reset(&dev->qdev);
> -
> qdev_init_gpio_out(&dev->qdev, s->out, ARRAY_SIZE(s->out));
>
> qdev_init_gpio_in(&dev->qdev, musicpal_gpio_pin_event, 32);
> --
> 1.6.0.2
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net