[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH, RFC 1/4] pci: add I/O registration function
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] Re: [PATCH, RFC 1/4] pci: add I/O registration functions |
Date: |
Fri, 28 May 2010 22:31:41 +0100 |
User-agent: |
KMail/1.13.3 (Linux/2.6.33-2-amd64; KDE/4.4.3; x86_64; ; ) |
> On Thu, May 27, 2010 at 2:39 PM, Michael S. Tsirkin <address@hidden> wrote:
> > On Sun, May 23, 2010 at 08:34:30PM +0000, Blue Swirl wrote:
> >> Convert also APB to use the registration so that
> >> we can remove mem_base.
> >>
> >> Signed-off-by: Blue Swirl <address@hidden>
> >> ---
> >> hw/apb_pci.c | 23 ++++++++++++++++++++-
> >> hw/pci.c | 64
> >> ++++++++++++++++++++++++++++++++++----------------------- hw/pci.h
> >> | 9 +++++++-
> >> 3 files changed, 68 insertions(+), 28 deletions(-)
> >
> > Probably should mention pci.c changes in the changelog.
>
> It's the subject.
IMO the body of the commit message should be self-contained. Many mail
clients display the body text separately from the subject - the subject tends
to be grouped with other metadata like to/from addresses.
This makes reading both as a whole confusing and unintuitive.
You can argue that this is a bug in git (and/or many mail clients). However I
don't see that changing any time soon, so we should adapt our work process
appropriately.
Some other version control systems (e.g. CVS and SVN) don't have commit
summary, so this can seem a strange concept when migrating from those systems.
Paul