Re: [Qemu-devel] [PATCH] target-ppc: remove useless line

[Andreas Färber]

Am 28.05.2010 um 21:00 schrieb Thomas Monjalon:

> From: Thomas Monjalon <address@hidden>
>
> This line was a bit clear.
> The next lines set or reset this bit (LE) depending of another bit  
> (ILE).
> So the first line is useless.
>
> Signed-off-by: Thomas Monjalon <address@hidden>
> ---
> target-ppc/helper.c |    1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/target-ppc/helper.c b/target-ppc/helper.c
> index 3d843b5..dabf1fd 100644
> --- a/target-ppc/helper.c
> +++ b/target-ppc/helper.c
> @@ -2591,7 +2591,6 @@ static inline void powerpc_excp(CPUState *env,  
> int excp_model, int excp)
> #if 0 /* Fix this: not on all targets */
>     new_msr &= ~((target_ulong)1 << MSR_PMM);
> #endif
> -    new_msr &= ~((target_ulong)1 << MSR_LE);
>     if (msr_ile)
>         new_msr |= (target_ulong)1 << MSR_LE;
>     else

Following line is
        new_msr &= ~((target_ulong)1 << MSR_LE);
so this should be fine.

Reviewed-by: Andreas Faerber <address@hidden>

Andreas