Re: [Qemu-devel] Re: [PATCH v2 12/15] monitor: Add basic device state visualization

[Jan Kiszka]

Avi Kivity wrote:
> On 05/29/2010 11:14 AM, Jan Kiszka wrote:
>>> Currently breaks down when IDs contain '/', but permitting that is a
>>> bug.  There may be more problems; the path lookup code is way too
>>> clever.
>>>      
>> Indeed. Less can sometimes be more. My impression is that some of the
>> cleverness was motivated by lacking qtree completion for the HMP.
>>    
> 
> Can we disable abbreviations for QMP and only allow them for HMP?
> 
> We can support that by adding a hidden argument to commands specifying
> whether the input comes from a human or machine.  Abbreviations are
> dangerous if they become ambiguous; a human can recover while a machine
> can't.
> 

Both QMP _and_ HMP suffer from ambitious and inconsistent addressing
schemes. Therefore, I'm more and more in favor of [1]. We just need to
add command line completion for option values, something that would be
beneficial for 'drive_add file=...' as well.

Jan

[1] http://article.gmane.org/gmane.comp.emulators.qemu/72152

signature.asc
Description: OpenPGP digital signature