qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 0/2] Setup scsi-bus xfer and xfer_mode for PR IN


From: Gerd Hoffmann
Subject: [Qemu-devel] Re: [PATCH 0/2] Setup scsi-bus xfer and xfer_mode for PR IN/OUT and Maintenance IN/OUT
Date: Mon, 31 May 2010 11:55:22 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Thunderbird/3.0.4

On 05/31/10 03:42, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger<address@hidden>

Greetings Gerd, Kevin and Co,

Attached are two patches to add the necesary CDB parsing to determine 
SCSIRequest->cmd.xfer
(length) and SCSIRequest->cmd.mode (direction) for Persistent Reservation IN/OUT
CDBs and for Maintenance IN/OUT CDBs used for Asymmetric Logical Unit Access, 
et al.
There is a special case for the latter Maintenance CDBs with TYPE_ROM that has 
been
included in scsi_req_length().

Also, I should mention this is a temporary measure in order to ensure that we 
can actually
do passthrough of these CDBs into KVM Guest for lsi and megaraid HBA emulation. 
 What will
need to eventually happen is to get rid of scsi_req_xfer_mode() all together 
and just setup
SCSIRequest->cmd.mode based on CDB type in scsi_req_length(), instead of having 
to have another
switch(cdb[0]) statement for every SCSI WRITE CDB on the planet to set 
SCSI_XFER_TO_DEV.

Anyways, I will look at doing this conversion in scsi_req_length() at some 
point, but please
apply these for the moment so folks can get access to their SPC-4 Port LUNs 
with QEMU.  ;)

Patches look fine to me.

Acked-by: Gerd Hoffmann <address@hidden>

cheers,
  Gerd



reply via email to

[Prev in Thread] Current Thread [Next in Thread]