qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH] qdev: Reject duplicate and anti-social device I


From: Gerd Hoffmann
Subject: [Qemu-devel] Re: [PATCH] qdev: Reject duplicate and anti-social device IDs
Date: Mon, 31 May 2010 20:55:16 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Thunderbird/3.0.4

On 05/31/10 16:13, Markus Armbruster wrote:
We need Device IDs to be unique and not contain '/' so device tree
nodes can always be unambigously referenced by tree path.

We already have some protection against duplicate IDs, but it got
holes:

* We don't assign IDs to default devices.

* -device and device_add use the ID of a qemu_device_opts.  Which
   rejects duplicate IDs.

* pci_add nic -net use either the ID or option "name" of
   qemu_net_opts.  And there's our hole.  Reproducible with "-net user
   -net nic,id=foo -device lsi,id=foo".

Also require IDs to start with a letter to provide for possible future
extensions.


Acked-by: Gerd Hoffmann <address@hidden>

cheers,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]