|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH 2/8] sparc64: fix missing address masking |
Date: | Tue, 01 Jun 2010 13:44:04 -0700 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-3.fc13 Thunderbird/3.0.4 |
On 06/01/2010 01:12 PM, Igor V. Kovalenko wrote: > + if ((env->pstate & PS_AM) && is_translating_asi(asi)) { > + addr &= 0xffffffffULL; > + } I suggest that these be written instead as if (is_translating_asi(asi)) { addr = address_mask(addr); } That should allow you to remove some of the ifdefs. r~
[Prev in Thread] | Current Thread | [Next in Thread] |