qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 7/9] QError: Introduce QERR_QMP_BAD_INPUT_OBJECT


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 7/9] QError: Introduce QERR_QMP_BAD_INPUT_OBJECT_MEMBER
Date: Wed, 02 Jun 2010 09:34:23 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)

Luiz Capitulino <address@hidden> writes:

> Signed-off-by: Luiz Capitulino <address@hidden>
> ---
>  qerror.c |    4 ++++
>  qerror.h |    3 +++
>  2 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/qerror.c b/qerror.c
> index 44d0bf8..b26224e 100644
> --- a/qerror.c
> +++ b/qerror.c
> @@ -177,6 +177,10 @@ static const QErrorStringTable qerror_table[] = {
>          .desc      = "QMP input object member '%(member)' expects 
> '%(expected)'",
>      },
>      {
> +        .error_fmt = QERR_QMP_INVALID_INPUT_OBJECT_MEMBER,
> +        .desc      = "QMP input object member '%(member)' is invalid",
> +    },
> +    {

"is invalid" can mean pretty much anything.  Let's call it "is
unexpected".  Update item 2. in qmp_check_client_args()'s function
comment, too.

>          .error_fmt = QERR_SET_PASSWD_FAILED,
>          .desc      = "Could not set password",
>      },
> diff --git a/qerror.h b/qerror.h
> index 77ae574..eec9949 100644
> --- a/qerror.h
> +++ b/qerror.h
> @@ -148,6 +148,9 @@ QError *qobject_to_qerror(const QObject *obj);
>  #define QERR_QMP_BAD_INPUT_OBJECT_MEMBER \
>      "{ 'class': 'QMPBadInputObjectMember', 'data': { 'member': %s, 
> 'expected': %s } }"
>  
> +#define QERR_QMP_INVALID_INPUT_OBJECT_MEMBER \
> +    "{ 'class': 'QMPInvalidInputObjectMember', 'data': { 'member': %s } }"
> +
>  #define QERR_SET_PASSWD_FAILED \
>      "{ 'class': 'SetPasswdFailed', 'data': {} }"



reply via email to

[Prev in Thread] Current Thread [Next in Thread]