[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/9] QMP: First half of the new argument checkin
|
From: |
Luiz Capitulino |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/9] QMP: First half of the new argument checking code |
|
Date: |
Wed, 2 Jun 2010 10:53:19 -0300 |
On Wed, 02 Jun 2010 08:59:11 +0200
Markus Armbruster <address@hidden> wrote:
> Luiz Capitulino <address@hidden> writes:
[...]
> > +
> > + type = qobject_to_qstring(obj);
> > + assert(type != NULL);
> > +
> > + if (qstring_get_str(type)[0] == 'O') {
> > + QemuOptsList *opts_list = qemu_find_opts(cmd_arg_name);
> > + assert(opts_list);
> > + res->result = check_opts(opts_list, res->qdict);
>
> I doubt this is the right place for calling check_opts.
Can you suggest the right place?
[Qemu-devel] [PATCH 2/9] Monitor: handle optional '-' arg as a bool, Luiz Capitulino, 2010/06/01
[Qemu-devel] [PATCH 5/9] QMP: Drop old client argument checker, Luiz Capitulino, 2010/06/01
[Qemu-devel] [PATCH 6/9] QMP: check_opts(): Minor cleanup, Luiz Capitulino, 2010/06/01
[Qemu-devel] [PATCH 4/9] QMP: Second half of the new argument checking code, Luiz Capitulino, 2010/06/01