qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [V9fs-developer] [PATCH] [virtio-9p] Flush the debu


From: Venkateswararao Jujjuri (JV)
Subject: Re: [Qemu-devel] Re: [V9fs-developer] [PATCH] [virtio-9p] Flush the debug message out to the log file.
Date: Wed, 02 Jun 2010 07:32:23 -0700
User-agent: Thunderbird 2.0.0.24 (Windows/20100228)

Aneesh Kumar K. V wrote:
> On Tue,  1 Jun 2010 13:23:09 -0700, "Venkateswararao Jujjuri (JV)" 
> <address@hidden> wrote:
>> This patch fluesh the debug messages to the log file  at the end of each
>> debug message.
>>
>> Signed-off-by: Venkateswararao Jujjuri <address@hidden>
>> ---
>>  hw/virtio-9p-debug.c |    2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/hw/virtio-9p-debug.c b/hw/virtio-9p-debug.c
>> index 2fb2673..5bfa689 100644
>> --- a/hw/virtio-9p-debug.c
>> +++ b/hw/virtio-9p-debug.c
>> @@ -481,4 +481,6 @@ void pprint_pdu(V9fsPDU *pdu)
>>      }
>>
>>      fprintf(llogfile, ")\n");
>> +    /* Flush the log message out */
>> +    fseek(llogfile, 0L, SEEK_CUR);
>>  }
> 
> 
> Why do one use fseek to flush ? why not fflush(3)

Good question. :) 
Even though functionally both are same, I will send a patch with fflush() as it 
is more straightforward. 

- JV

> 
> -aneesh
> 





reply via email to

[Prev in Thread] Current Thread [Next in Thread]