[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 8/9] QMP: Introduce qmp_check_input_obj()
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 8/9] QMP: Introduce qmp_check_input_obj() |
Date: |
Wed, 02 Jun 2010 16:42:17 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Luiz Capitulino <address@hidden> writes:
> On Wed, 02 Jun 2010 09:39:26 +0200
> Markus Armbruster <address@hidden> wrote:
>
>> Luiz Capitulino <address@hidden> writes:
>>
>> > This is similar to qmp_check_client_args(), but checks if
>> > the input object follows the specification (QMP/qmp-spec.txt
>> > section 2.3).
>> >
>> > As we're limited to three keys, the work here is quite simple:
>> > we iterate over the input object, each time checking if the
>> > given argument complies to the specification.
>> >
>> > Signed-off-by: Luiz Capitulino <address@hidden>
>> > ---
>> > monitor.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
>> > 1 files changed, 45 insertions(+), 0 deletions(-)
>> >
>> > diff --git a/monitor.c b/monitor.c
>> > index 1875731..654b193 100644
>> > --- a/monitor.c
>> > +++ b/monitor.c
>> > @@ -4271,6 +4271,45 @@ static int qmp_check_client_args(const mon_cmd_t
>> > *cmd, QDict *client_args)
>> > return res.result;
>> > }
>> >
>> > +/*
>> > + * Input object checking rules
>> > + *
>> > + * 1. "execute" key must exist (not checked here)
>> > + * 2. "execute" key must be a string
>> > + * 3. "arguments" key must be a dict
>> > + * 4. "id" key can be anything (ie. json-value)
>>
>> Really? Checking qmp-spec.txt... yes, really. Is it a good idea to
>> permit objects and arrays?
>
> It was Avi's suggestion to allow anything, maybe arrays don't make sense
> but objects do.
If we permit objects, we can just as well permit anything.
- Re: [Qemu-devel] [PATCH 4/9] QMP: Second half of the new argument checking code, (continued)
- Re: [Qemu-devel] [PATCH 4/9] QMP: Second half of the new argument checking code, Markus Armbruster, 2010/06/02
- [Qemu-devel] Handling the O-type, Luiz Capitulino, 2010/06/18
- Re: [Qemu-devel] Handling the O-type, Markus Armbruster, 2010/06/21
- Re: [Qemu-devel] Handling the O-type, Luiz Capitulino, 2010/06/21
- Re: [Qemu-devel] Handling the O-type, Markus Armbruster, 2010/06/21
[Qemu-devel] [PATCH 7/9] QError: Introduce QERR_QMP_BAD_INPUT_OBJECT_MEMBER, Luiz Capitulino, 2010/06/01
[Qemu-devel] [PATCH 8/9] QMP: Introduce qmp_check_input_obj(), Luiz Capitulino, 2010/06/01
[Qemu-devel] [PATCH 9/9] QMP: Drop old input object checking code, Luiz Capitulino, 2010/06/01
Re: [Qemu-devel] [PATCH 0/9]: QMP: Replace client argument checker, Markus Armbruster, 2010/06/02