[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC] [PATCH 0/5] Add horizontal wheel support to mice,
From: |
Brad Jorsch |
Subject: |
Re: [Qemu-devel] [RFC] [PATCH 0/5] Add horizontal wheel support to mice, where possible |
Date: |
Wed, 2 Jun 2010 12:14:47 -0400 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Wed, Jun 02, 2010 at 08:30:11AM -0500, Anthony Liguori wrote:
>
> I think instead of adding an additional parameter for horizontal
> wheel, we should look at making the API capable of
> accepting/generating arbitrary button presses.
>
> Really, we should just drop dz and treat vertical wheel as two
> button presses within button_state. Likewise, horizontal wheel
> should just be two additional bits within button_state.
Wheel handling in cocoa.m and in monitor.c may supply a delta greater
than 1 for the mouse wheels. Those front-ends would have to translate
those deltas into a series of press+release events. Then the emulated
devices (at least the PS/2 and USB devices) would have to sum the
designated button presses for outputting again as wheel data.
If that's the way we want to go, I can rework the patch easily enough.