[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/16] clean up vl.c code
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 00/16] clean up vl.c code |
Date: |
Fri, 04 Jun 2010 10:21:07 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
address@hidden writes:
> From: Jes Sorensen <address@hidden>
>
> Hi,
>
> I have been working on a set of patches to clean up the vl.c code, by
> separating out OS specific code into OS specific files. Basically it
> introduces two header files: qemu-os-win32.h and qemu-os-posix.h as
> well as os-win32.c and os-posix.c.
>
> I have tried to be as careful as I can to not break non Linux support,
> but as I only have a Linux build environment handy, I would appreciate
> it if people with other OSes could check that I didn't break anything
> for them. In particular I would like to know if win32 still builds.
I like moving stuff out of vl.c in general. Your moves of entire
functions look like a win to me. I have doubts about spreading the
option switch over three files, though.
- Re: [Qemu-devel] [PATCH 10/16] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c, (continued)
[Qemu-devel] [PATCH 13/16] Move daemonize handling to OS specific files, Jes . Sorensen, 2010/06/03
[Qemu-devel] [PATCH 15/16] Move line-buffering setup to OS specific files., Jes . Sorensen, 2010/06/03
[Qemu-devel] [PATCH 16/16] Move set_proc_name() to OS specific files., Jes . Sorensen, 2010/06/03
Re: [Qemu-devel] [PATCH 00/16] clean up vl.c code,
Markus Armbruster <=