[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 3/3] blockdev: Collect block device code in new
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] Re: [PATCH 3/3] blockdev: Collect block device code in new blockdev.c |
Date: |
Fri, 04 Jun 2010 12:43:29 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Thunderbird/3.0.4 |
Am 02.06.2010 18:16, schrieb Markus Armbruster:
> Kevin Wolf <address@hidden> writes:
>
>> Am 02.06.2010 13:31, schrieb Markus Armbruster:
>>> Anything that moves hundreds of lines out of vl.c can't be all bad.
>>>
>>> Signed-off-by: Markus Armbruster <address@hidden>
>>
>> New files need a license header, otherwise it looks ok.
>>
>> I have applied this patch (and the other ones, too) to the block branch
>> anyway to avoid conflicts with other people basing their patches on that
>> branch. However, it requires a v2 before I can propose this to be merged
>> into master.
>
> vl.c has "Copyright (c) 2003-2008 Fabrice Bellard". monitor.c has
> "Copyright (c) 2003-2004 Fabrice Bellard". Would the following header
> do?
>
> /*
> * QEMU host block devices
> *
> * Copyright (c) 2003-2008 Fabrice Bellard
> *
> * This work is licensed under the terms of the GNU GPL, version 2 or
> * later. See the COPYING file in the top-level directory.
> */
Should be good enough, I think.
vl.c and monitor.c are BSD licensed, though. Not sure if anyone minds if
the license is changed to GPL. Probably not, just want to have it mentioned.
Kevin