[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] target-i386: fix decoding of negative 4-byte displa
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH] target-i386: fix decoding of negative 4-byte displacements |
Date: |
Fri, 4 Jun 2010 16:27:33 +0200 |
Negative four byte displacements need to be sign-extended after
c086b783eb7a578993d6d2ab62c4c2666800b63d. Do so.
Signed-off-by: Paolo Bonzini <address@hidden>
---
There are quite a few other ldl's to audit after the patch
(about 70 in target-*). Any volunteers? :-)
target-i386/translate.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index 38c6016..708b0a1 100644
--- a/target-i386/translate.c
+++ b/target-i386/translate.c
@@ -2016,7 +2016,7 @@ static void gen_lea_modrm(DisasContext *s, int modrm, int
*reg_ptr, int *offset_
break;
default:
case 2:
- disp = ldl_code(s->pc);
+ disp = (int32_t)ldl_code(s->pc);
s->pc += 4;
break;
}
--
1.7.0.1
[Qemu-devel] [PATCH 3/8] sparc64: fix 32bit load sign extension, Igor V. Kovalenko, 2010/06/01
- [Qemu-devel] Re: [PATCH 3/8] sparc64: fix 32bit load sign extension, Paolo Bonzini, 2010/06/03
- [Qemu-devel] Re: [PATCH 3/8] sparc64: fix 32bit load sign extension, Alexander Graf, 2010/06/03
- [Qemu-devel] Re: [PATCH 3/8] sparc64: fix 32bit load sign extension, Paolo Bonzini, 2010/06/03
- [Qemu-devel] Re: [PATCH 3/8] sparc64: fix 32bit load sign extension, Igor Kovalenko, 2010/06/03
- [Qemu-devel] Re: [PATCH 3/8] sparc64: fix 32bit load sign extension, Paolo Bonzini, 2010/06/04
- [Qemu-devel] Re: [PATCH 3/8] sparc64: fix 32bit load sign extension, Paolo Bonzini, 2010/06/04
- [Qemu-devel] [PATCH] target-i386: fix decoding of negative 4-byte displacements,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH] target-i386: fix decoding of negative 4-byte displacements, Richard Henderson, 2010/06/04
- Re: [Qemu-devel] [PATCH] target-i386: fix decoding of negative 4-byte displacements, Blue Swirl, 2010/06/04
[Qemu-devel] [PATCH 4/8] sparc64: fix ldxfsr insn, Igor V. Kovalenko, 2010/06/01
[Qemu-devel] [PATCH 5/8] sparc64: use symbolic name for MMU index, Igor V. Kovalenko, 2010/06/01
[Qemu-devel] [PATCH 6/8] sparc64: improve ldf and stf insns, Igor V. Kovalenko, 2010/06/01
[Qemu-devel] [PATCH 8/8] sparc64: fix umul and smul insns, Igor V. Kovalenko, 2010/06/01
[Qemu-devel] [PATCH 7/8] sparc64: fix udiv and sdiv insns, Igor V. Kovalenko, 2010/06/01
Re: [Qemu-devel] [PATCH 0/8] sparc64 fixes, Blue Swirl, 2010/06/02