Re: [Qemu-devel] [PATCH 00/10] target-mips: add microMIPS ASE support, v2

[Richard Henderson]

On 05/24/2010 09:19 AM, Nathan Froyd wrote:
> This patch series adds support for the microMIPS ASE.  microMIPS is a
> new ASE similar to MIPS16, but re-encodes the entire instruction set
> into 16-bit and 32-bit instructions--in contrast to MIPS16, which
> re-encodes only integer instructions.  The mechanisms for going in and
> out of microMIPS mode are identical to those for MIPS16; a given chip
> cannot support both ASEs simultaneously.

The review that follows doesn't include verification of the ASE, as

  http://www.mips.com/products/product-materials/processor/mips-architecture/

doesn't list Volume IV-g yet.  I'm only going to look at style and
other possible coding errors.


r~